Page 1 of 1

[z88dk-dev] The SDCC patch

Posted: Thu Apr 13, 2017 9:25 pm
by Philipp Klaus Krause
Dear z88dk developers,

oncce in a while, I take a look at your patch
https://github.com/z88dk/z88dk/blob/master/libsrc/_DEVELOPMENT/sdcc_z88dk_patch.zip
to see if there is something that should be added upstream.

Unfortunately, this is becoming a bigger effort due to the patch
containing many cosmetic changes (e.g. changes to indentation, adding or
removing empty lines or whitespace).

Is there a particular reason those need to be in the patch?

Philipp

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Posted: Fri Apr 14, 2017 1:37 am
by alvin
Unfortunately, this is becoming a bigger effort due to the patch
containing many cosmetic changes (e.g. changes to indentation, adding or
removing empty lines or whitespace).

Is there a particular reason those need to be in the patch?

No, it's just that I haven't put in the effort to clear that up.

The reason is I want to move away from the patch. There is a separate github repository set up for zsdcc here:
https://github.com/z88dk/zsdcc

I already use it to build the windows binary. There are three branches in there (master, sdcc-patch and zsdcc).
The zsdcc branch is the code with modifications as we are using it now. Master holds the unmodified sdcc code base
as reflected from sourceforge by svn2github. Sdcc-patch is going to be a clean integration of our changes in zsdcc.
The modifications in zsdcc are hackish and I'd like to do it properly in that branch with the knowledge I have now of
how things work. This branch will eventually become the "zsdcc branch" and it's this branch that we can propose
patches to sdcc from.



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot